Skip to content

boards: nordic: nrf54h20dk iron board MCUBoot support #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

boards: nordic: nrf54h20dk iron board MCUBoot support #2720

merged 2 commits into from
Apr 15, 2025

Conversation

@nordic-mik7
Copy link
Contributor

@nordic-mik7 nordic-mik7 commented Apr 7, 2025 •
edited
Loading

Provide proper adaptions as bootloader ROM offset, flash load
offset and dts definitions for the nRF54H20 iron board to make it
ready for the MCUBoot bootloader.

Adding smp_svr sample configuration for nRF54H20dk 'iron' board.

Ref: NCSDK-32929

@NordicBuilder NordicBuilder mentioned this pull request Apr 7, 2025
Closed
nordicjm
nordicjm requested changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to go upstream (have read comment but ipc should be working in upstream, if it is not then I don't see how this would even work in ncs)

@nordic-mik7 nordic-mik7 force-pushed the dev/lillium_mcuboot_support_push branch from 638dabb to aa73fec Compare April 7, 2025 12:56
@nordic-mik7 nordic-mik7 force-pushed the dev/lillium_mcuboot_support_push branch 5 times, most recently from 8c09304 to 4dfec32 Compare April 8, 2025 12:55
ahasztag
ahasztag reviewed Apr 8, 2025
View reviewed changes
@nordic-mik7
Copy link
Contributor Author

nordic-mik7 commented Apr 8, 2025

this needs to go upstream (have read comment but ipc should be working in upstream, if it is not then I don't see how this would even work in ncs)

I decoupled upstream changes in seperate commit now. As for smp_svr sample, please see
https://nordicsemi.atlassian.net/browse/NCSDK-32929 and related converastion started there.

@nordic-mik7 nordic-mik7 requested a review from nordicjm April 8, 2025 13:07
@nordic-mik7 nordic-mik7 force-pushed the dev/lillium_mcuboot_support_push branch from 4dfec32 to fe27793 Compare April 9, 2025 11:27
@nordic-mik7 nordic-mik7 requested a review from ahasztag April 9, 2025 11:29
@nordic-mik7 nordic-mik7 changed the title [nrf noup] smp_svr: nrf54h20dk serial sample smp_svr: nrf54h20dk serial sample Apr 9, 2025
carlescufi
carlescufi requested changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider extending the sample like this instead:
https://github.com/nrfconnect/sdk-nrf/tree/main/samples/zephyr

@nordic-mik7 nordic-mik7 force-pushed the dev/lillium_mcuboot_support_push branch from fe27793 to c8161ff Compare April 10, 2025 07:31
@nordic-mik7 nordic-mik7 changed the title smp_svr: nrf54h20dk serial sample boards: nordic: nrf54h20dk iron board MCUBoot support Apr 10, 2025
@nordic-mik7
Copy link
Contributor Author

nordic-mik7 commented Apr 10, 2025

Please consider extending the sample like this instead: https://github.com/nrfconnect/sdk-nrf/tree/main/samples/zephyr

Please see changed sample related commit - now upstreamed and simplified.
Team decided to extend sample in here because smp_svr is a base sample for MCUBoot integration on boards.

@nordic-mik7 nordic-mik7 requested a review from carlescufi April 10, 2025 08:01
@nordic-mik7 nordic-mik7 force-pushed the dev/lillium_mcuboot_support_push branch from c8161ff to c433a90 Compare April 11, 2025 07:19
@ahasztag ahasztag self-requested a review April 11, 2025 08:42
@ahasztag
Copy link
Contributor

ahasztag commented Apr 11, 2025

Needs a corresponding PR in sdk-nrf bumping sdk-zephyr to pull/2720/head in order to run tests on sdk-nrf.

@NordicBuilder NordicBuilder mentioned this pull request Apr 11, 2025
Merged
@nordic-mik7
Copy link
Contributor Author

nordic-mik7 commented Apr 11, 2025

Needs a corresponding PR in sdk-nrf bumping sdk-zephyr to pull/2720/head in order to run tests on sdk-nrf.

Here it is nrfconnect/sdk-nrf#21686
Related MCUBoot changes should be already aligned.

@ahasztag ahasztag force-pushed the dev/lillium_mcuboot_support_push branch 6 times, most recently from 33ce4b4 to a9006a9 Compare April 14, 2025 11:37
@nordic-mik7 @ahasztag
[nrf fromlist] boards: nordic: nrf54h20dk iron board MCUBoot support
d41deb7 
Provide proper adaptions as bootloader ROM offset, flash load
offset and dts definitions for the nRF54H20 iron board to make it
ready for the MCUBoot bootloader.

Upstream PR #: 88576

Signed-off-by: Michal Kozikowski <[email protected]>
@nordic-mik7 @ahasztag
[nrf fromlist] samples: smp_svr: nrf54h20dk 'iron' board serial DFU
fdf51a6 
Adding sample configuration for nRF54H20dk 'iron' board.

Upstream PR #: 88576

Signed-off-by: Michal Kozikowski <[email protected]>
@ahasztag ahasztag force-pushed the dev/lillium_mcuboot_support_push branch from a9006a9 to fdf51a6 Compare April 14, 2025 12:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rlubos rlubos merged commit b3fa7c5 into nrfconnect:main Apr 15, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlescufi carlescufi carlescufi approved these changes

@nordicjm nordicjm nordicjm approved these changes

@ahasztag ahasztag ahasztag approved these changes

@tomchy tomchy Awaiting requested review from tomchy

@adsz-nordic adsz-nordic Awaiting requested review from adsz-nordic

@jnsgsr jnsgsr Awaiting requested review from jnsgsr

@robertstypa robertstypa Awaiting requested review from robertstypa

@kszromek-nordic kszromek-nordic Awaiting requested review from kszromek-nordic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nordic-mik7 @ahasztag @carlescufi @nordicjm @rlubos